Various mod improvements

OpenBazaar / openbazaar-desktop

OpenBazaar 2.0 Desktop Client (talks to openbazaar-go server daemon)

MIT License

647 stars 186 forks source link

Various mod improvements #1864

Open jjeffryes opened 4 years ago

jjeffryes commented 4 years ago

This adds the same changes from #1859 and #1861 to the eth-master branch.

This also closes #1862.

This is built on top of #1863, and should not be merged until that branch is merged. The WIP label is just there to make sure that doesn't happen.

rmisio commented 4 years ago

@jjeffryes Would you mind updating this with the latest eth-master (I merged #1863) so the change-set is a little lighter?

jjeffryes commented 4 years ago

@rmisio I merged in eth-master, it's a lot more sane now. :)

rmisio commented 4 years ago

When I search for a mod, I get double "loading" texts:

rmisio commented 4 years ago

@jjeffryes One other thing I noticed is that it appears that when I toggle the Verified Moderators checkbox the whole payment screen is re-rendering. I haven't looked in the code, but I'm basing that on the fact that the images across the whole view flicker.

If that's the case, seems way too heavy handed. I would think that upon toggle just the moderators view would need some state updated.

Anyhow, I know that probably wasn't introduced in this PR, so let me know if it's better I just log an issue we could prioritize for some other time?

rmisio commented 4 years ago

@jjeffryes Also please let me know if I should log a seperate issue for this or if you want to fix it in this PR:

https://github.com/OpenBazaar/openbazaar-desktop/issues/1862#issuecomment-581659203

jjeffryes commented 4 years ago

@jjeffryes One other thing I noticed is that it appears that when I toggle the Verified Moderators checkbox the whole payment screen is re-rendering. I haven't looked in the code, but I'm basing that on the fact that the images across the whole view flicker.

If that's the case, seems way too heavy handed. I would think that upon toggle just the moderators view would need some state updated.

Anyhow, I know that probably wasn't introduced in this PR, so let me know if it's better I just log an issue we could prioritize for some other time?

I'll see if I can fix that with a reasonable amount of effort when revising this PR, if not I'll create a new issue for it.

jjeffryes commented 4 years ago

I made a separate issue for future rendering optimization. https://github.com/OpenBazaar/openbazaar-desktop/issues/1866

The rest of this should be ready for re-review.