search

OpenBazaar / openbazaar-desktop

OpenBazaar 2.0 Desktop Client (talks to openbazaar-go server daemon)
MIT License
648 stars 186 forks source link

When store is off, products can still be accessed through search results #830

Open ghost opened 7 years ago

ghost commented 7 years ago

v.2.0.11 win7 64 bits

My store is "off" in settings and I get the message "Your store is currently inactive and hidden from the public.".

Search providers still display my listings and they can be accessed through search results. Users can still buy.

When you try to access through address bar, they are not accessible ("This Page Could Not Be Found").

jjeffryes commented 7 years ago

@rmisio can you take a look at this?

rmisio commented 7 years ago

I think the code to handle inactive stores is in the router, but the search doesn't go through the router. I'll look into integrating it into search (or maybe the listing detail modal).

@jjeffryes Do you think the server should also prevent purchases for inactive stores?

jjeffryes commented 7 years ago

Is that happening in search, or the listing card?

I think the server should prevent purchases if your vendor flag is set to false.

@cpacia does that check happen in the server?

jjeffryes commented 7 years ago

The issue for the server to prevent purchases if vendor is false is tracked here: https://github.com/OpenBazaar/openbazaar-go/issues/683