Validate mnemonic inputs

placer14 commented 5 years ago

Currently, any amount of entropy can be passed in to generate a new identity seed. To prevent the user from accidentally using an invalid mnemonic, we should validate the mnemonic against the bip39 package we use in ob-go instead of assuming it's valid.

Todo:

[x] identify all possible places we accept a mnemonic
[ ] identify common paths of all inputs to find the best location to patch with least duplicated code
[ ] update usages of bip39.NewSeed to use bip39.NewSeedWithErrorChecking and properly handle errors

Inputs to patch:

[ ] cmd/start.go accepts as a parsed flag
[ ] cmd/restore.go accepts as a parsed flag
[ ] cmd/init.go accepts as a parsed flag
[ ] schema/manager.go should handle this validation as well
[ ] mobile/node.go accepts as arg
[ ] wallet/builder.go appears to process it, unsure if validation is required here

placer14 commented 5 years ago

Related to #1397

cpacia commented 5 years ago

It is standard practice to accept any string as a mnemonic and not force it to be a specific string. This allows users to use a custom seed .. such as one with more entropy if they want.

placer14 commented 5 years ago

I wasn't aware of this practice. Then what is the point of the Valid check in the mnemonic package? Should we raise a warning while still accepting the "invalid" input?

OpenBazaar / openbazaar-go

Validate mnemonic inputs #1316