search

OpenBazaar / openbazaar-go

OpenBazaar 2.0 Server Daemon in Go
MIT License
993 stars 283 forks source link

Consider changes made for mobile improvement for master #1609

Open placer14 opened 5 years ago

placer14 commented 5 years ago

Some tweaks were applied by the mobile team to improve various aspects of daemon performance. We should consider which changes might be valuable in master.

https://github.com/OpenBazaar/openbazaar-go/compare/mobileFixes

drwasho commented 5 years ago

Some of these changes were adopted by Zokos IIRC (ping @rodkeys) and the key benefits are:

  1. Service start times are almost immediate
  2. Publishing at startup takes >30 seconds instead of several minutes
  3. Publishing any content after startup is > ~10 seconds
  4. Send offline messages if the peer can't be reached online in 3 seconds

I haven't observed any problems fetching content from the network, and considering the addition of the APIRouter I think we can afford to adopt shorter timeouts. For (4), 3 seconds may seem a bit aggressive for mobile, but since we're using relay nodes it's probably reasonable; for desktop it could probably reduced to 10 seconds.