search

OpenBazaar / openbazaar-go

OpenBazaar 2.0 Server Daemon in Go
MIT License
994 stars 283 forks source link

Not documented that you have to fill sha256 password hash #1650

Open Franselbaer opened 5 years ago

Franselbaer commented 5 years ago

https://github.com/OpenBazaar/openbazaar-go/blob/8ec3315f80da3537d2a482ca16f351347d5488e8/api/ws.go#L129

I tried to seperate server and client and had a lot of fun configuring auth for JSon API until I got a connection to the server.

    "JSON-API": {
        "Password": "8c6976e_testtesttest_ab448a918",
        "Username": "testtesttest"
    },

Nowhere is written that password needs to be a sha256 hash. You'd better put that in howto....

placer14 commented 5 years ago

The primary places for this documentation would be in either https://docs.openbazaar.org or in the docs folder in openbazaar-go: https://github.com/OpenBazaar/openbazaar-go/tree/master/docs.

Please update all relavent docs appropriately.

abc516 commented 4 years ago

Hi @placer14 . I'd be open to tackling this issue

placer14 commented 4 years ago

Thanks for the offer @abc516. If you haven't already found it, this update should probably be under Authentication at https://docs.openbazaar.org/reference/api/http/#authentication. This can be updated at https://github.com/OpenBazaar/official_docs/tree/master/content. I realize there are not docs generated at that repo. I would validate the markdown in an editor if you are unable to decipher the makefile. We would also welcome a README pull request for the docs repo if you feel extra motivated. 🍻