OpenBazaar / openbazaar-go

OpenBazaar 2.0 Server Daemon in Go
MIT License
991 stars 284 forks source link

Upgrade go-bip39 lib to fix a validation problem #1676

Open tyler-smith opened 4 years ago

tyler-smith commented 4 years ago

The current version used does not validate checksums correctly and an update has been issued upstream.

abc516 commented 4 years ago

Hi @tyler-smith @placer14 I'd be open to tackling this. Any tips on how to proceed?

placer14 commented 4 years ago

It looks like this was talked about briefly in https://github.com/OpenBazaar/openbazaar-go/issues/1316. @cpacia suggests (in https://github.com/OpenBazaar/openbazaar-go/issues/1316#issuecomment-467052521) that we aren't meant to validate these inputs. I'll ask @cpacia and @tyler-smith what they think and get some details in here.