search

OpenBazaar / openbazaar-go

OpenBazaar 2.0 Server Daemon in Go
MIT License
994 stars 283 forks source link

CurrencyDictionary needs to support non-wallet cryptocurrencies #1710

Open placer14 opened 5 years ago

placer14 commented 5 years ago

Currently non-wallet cryptocurrencies will not be found in the currency dictionary. This dictionary is used by repo.Listing to ensure the listing is valid. In connection with automating the generation of these currencies (which are likely to change often) described in https://github.com/OpenBazaar/openbazaar-go/issues/1691, we want these currencies to be looked up from the dictionary instead of assuming their divisibility and other details.

rmisio commented 5 years ago

we want these currencies to be looked up from the dictionary instead of assuming their divisibility and other details

The divisibility is not assumed because it's in the listing and should be provided by the client in relevant APIs.