OpenBeerMap / OpenBeerMap.github.io

Visualiser et éditer les bières pressions disponibles dans les bars.
http://openbeermap.github.io/
MIT License
92 stars 48 forks source link

NYC #26

Closed brianegge closed 9 years ago

brianegge commented 10 years ago

In NYC, the map shows mostly Dunkin Donuts and Starbucks. We have many POIs tagged amenity=cafe; but cuisine=donut or cuisine=coffee shop. I don't think cafe's should be shown unless they have a brewery tag or pub=yes.

OpenBeerMap commented 9 years ago

Thank you for your feedback.

Can you see any improvements in NYC on the dev website : http://nlehuby.github.io/ ? I removed the amenity=cafe with cuisine = coffee_shop from the OSM API call.

I don’t want to restrict too much on the OSM call because

brianegge commented 9 years ago

Thanks!

Yes, it's much better. The coffee shops that do show up can now be tagged so they are filtered out. Cafe can mean just about anything, and sometimes it's a beer garden and other times it's a coffee shop.

I've been having a bit of fun exploring with the beer map.

Did you know that overpass can now return centers of areas? (Not strictly centroids though). It's pretty useful because many POIs are mapped as closed ways.

http://wiki.openstreetmap.org/wiki/Overpass_API/Overpass_QL#Print_.28out.29

Cheers, Brian

On Oct 6, 2014, at 10:34 AM, OpenBeerMap notifications@github.com wrote:

Thank you for your feedback.

Can you see any improvements in NYC on the dev website : http://nlehuby.github.io/ ? I removed the amenity=cafe with cuisine = coffee_shop from the OSM API call.

I don’t want to restrict too much on the OSM call because

I want the user to be able to find his “bar” on the website : I prefer to show too many items over missing some items. Many people told me that cafe does not have beer in their country, but almost 10% of the beer contributions are on amenity=cafe, so I could not just remove this tag … I want to minimize the request time : a very difficult overpass request means a very long time to gather the data and display the bars — Reply to this email directly or view it on GitHub.

OpenBeerMap commented 9 years ago

Thanks for feedbacks.

The dev website (http://nlehuby.github.io/) already displays beer providers tagged as ways using the center of the closes ways (but they cannot be edited yet). Feel free to tell me on the other issue if you notice any problems or missing amenities.

Happy contributing !