Missing update after changing favourite beer

[michael-k]

Refers to: http://nlehuby.github.io/

1. Go to a bar that serves guinness and open its “Edit bar information” dialog.
2. Click on “Customize”, remove all beers and add them (or at least guinness) again.
3. The “Edit bar information” dialog is not updated and guinness doesn't seem to be served.
4. Close the “Edit bar information” dialog and open it again. All is back to normal as in step 1.

Another issue that appears after this is, that there is no way to remove the guinness bars from the map. Those displayed in step 1 will always be visible until you reload the page. In the last image you can see that guinness (on the right side) is not selected, but the bar is still shown on the map.

[nlehuby]

Hi Mikael,

thank you for your feedback !

I cannot reproduce your bug at all ... Did you test the very last version on nlehuby.github.io ? I've seen bugs like this in previous versions of the app, but it seems to me that they all have been fixed by now.

Here is what i can see :

Go to a bar that serves guinness and open its edit bar information dialog

ok

Click on Customize, remove all beers, and them back

ok. The bars that serves Guinness already displayed on the map disappeared. Guinness is displayed twice in the edit bar dialog : one is selected, the other not (data issue with the capital letters ; does not impact the beer data registered to OSM).

Please let me know !

[michael-k]

I did test it with http://nlehuby.github.io on Firefox 35.0.1

The bars that serves Guinness already displayed on the map disappeared.

I observed that it works sometimes, but doesn't always.

1. Open http://nlehuby.github.io (hard reload; maybe even clear the local storage)
2. Select only layer “Guinness”
3. Open bar information and keep all dialogs open
4. Customize → Clear list; see how the guinness layer has disappeared, but not the layer links on the right
5. Close the display settings dialog and the bar information dialog (Update: don't save!). Select layer “guinness”, open bar information and keep everything open as in step 3 (first image).
6. Customize → add “guinness”, now it is displayed twice (without any data issue regarding capital letters; OSM database: brewery = chouffe;guinness;affligem;tripel_karmeliet;kwak;san miguel). I'm not sure at which point the layer list updated. I played around a lot. I had enough cases where it didn't update. (Update: I guess I hit save once when in Customize.)
7. Clear list; see how the layer didn't disappear (and no "remove layer" in the brower's console)

Guinness is displayed twice in the edit bar dialog : one is selected, the other not (data issue with the capital letters ; does not impact the beer data registered to OSM).

As you can see above, I also found ways to display it twice without any data issues regarding capital letters. You shouldn't have problems with capital letters anyway. Just lowercase everything when comparing.

[nlehuby]

Ok, got it.

TODO :

• remove the cancel button
• refresh beers list in the control + refresh beers list in the edit bar modal when an action is performed with the favourite beers
• create another issue about the beer displayed twice

[nlehuby]

I've patched #40 Could you please click around to check if you can still reproduce ?

[michael-k]

The removed and then added beer still pops up twice in “Bar edition” → “Available draft beers”. The correct list is displayed after reopening the dialog.

Other than that, it works. :+1:

Here are some improvements to “Customize” I suggest:

• The “Save” button should be renamed to “Close”. It should be on the right. (This is where – in my experience – close buttons are in general.)
• The “Clear list” button should be on the left, because the list is on the left (at least on wide displays).
• The “Add favourite beer” input should add the beer on enter (key event). (Same for “Add beer” in “Bar edition”). I could've created issues for all of them, but the changes necessary seemed to small and are related to the changes made in regard of this issue.