search

OpenBeta / open-tacos

Rock climbing route catalog (openbeta.io)
https://openbeta.io
GNU Affero General Public License v3.0
110 stars 111 forks source link

feat: Improve UI with icon updates and font change Updated #1090

Closed athuv closed 4 months ago

athuv commented 5 months ago

What this PR achieves

The previous pull request (#1084 ) had some unwanted changes due to the initial rebase attempt. This pull request corrects those issues and provides a cleaner set of changes for review.

Issue #1079

vercel[bot] commented 5 months ago

@athuv is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

vnugent commented 5 months ago

@athuv still a lot of changes. Please have a look at the Files tab https://github.com/OpenBeta/open-tacos/pull/1090/files

athuv commented 5 months ago

still a lot of changes. Please have a look at the Files tab

@vnugent Thank you for taking the time to review my contribution. As I'm relatively new to open source contributions, I'm still learning the best practices around rebasing and managing pull requests. Could you kindly provide some guidance or direct me to resources where I can learn more about the rebase process and how to align my pull request with the project's standards?

vnugent commented 5 months ago

Since your change is very small I would abandon the current fork repo and start from scratch:

  1. Clone your fork to a different working dir
  2. Create a new working branch in the new working dir
  3. In VSC identify changes you made in the previous working dir and replicate them in the new dir
  4. git push

Example:

 # clone your fork to 'openbeta-new' dir
git clone git@github.com:athuv/open-tacos.git openbeta-new
cd openbeta-new
git checkout -b feat-1079
# then copy changes from previous working dir
# git commit and git push