OpenBeta / open-tacos

Rock climbing route catalog (openbeta.io)
https://openbeta.io
GNU Affero General Public License v3.0
110 stars 111 forks source link

Map doesn't reflect the latest coordinates of an area #1095

Closed heliodor closed 4 months ago

heliodor commented 4 months ago

I updated the coordinates for an area and the map hasn't been updated (even minutes later).

Tried it for two more sub-areas and the same problem.

Or maybe it's a shortcoming of the current design but from the user's point of view, it's a bug.

heliodor commented 4 months ago

Example: click the link with the coordinates and compare to the map at the bottom of the page: https://openbeta.io/area/cb5ef655-d4ad-576a-9acc-7ba2a83fefb3/la-escalera

vnugent commented 4 months ago

Pending backend PR 391 will update the maptiles as frequently as possible.

FYI in recent backend changes only coordinates of leaf (aka "crag") areas are used to calculate their parent's bounding boxes and the polygon since it doesn't make sense for a large area to have a single point.

The area edit page needs to disable/enable coordinates edit based on the isLeaf attribute.

heliodor commented 4 months ago

To add some nuance to the coordinates of an area:

It makes sense to put the coordinates of a crag on the parking lot, not the actual rock. It fits my mental model: If I'm at home and I think of heading to ABC crag, I'm thinking of the parking lot, not a particular rock. When I think of going to a sector, I'm thinking of the actual rock.

But really, this is making up for the lack of certain details for the area. Maybe areas should have one or more "arrival points" with coordinates. Or even more detailed fields. Consider incorporating all approach trails into the bounding box for the area.

vnugent commented 4 months ago

The maptiles exporter job now runs every 2 hrs (can be adjusted as needed). I'll submit a new PR for enabling/disabling area coordinates input when it makes sense.

Please continue the finer-grained area metadata discussion here: https://github.com/OpenBeta/open-tacos/issues/1101

vnugent commented 4 months ago

Fixed in https://github.com/OpenBeta/openbeta-graphql/pull/391 and #1102