OpenBeta / open-tacos

Rock climbing route catalog (openbeta.io)
https://openbeta.io
GNU Affero General Public License v3.0
133 stars 117 forks source link

WIP: feat: area topo drawing #1099

Closed btmccord closed 7 months ago

btmccord commented 7 months ago

name: Pull request about: Topo Drawing title: '' labels: '' assignees: ''


What type of PR is this?(check all applicable)

Description

Related Issues

Issue #1085

What this PR achieves

WIP Preview of topo drawing. Adds a manage topos page under area edit. There are three hard-coded photos to draw on for testing purposes.

Screenshots, recordings

Screenshot 2024-02-19 at 21-42-12 Manage topos in area White Wall The

Notes

This is very much a work in progress for feedback on the layout and features

vercel[bot] commented 7 months ago

@btmccord is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Feb 22, 2024 4:10pm
vnugent commented 7 months ago

@btmccord can I go ahead and merge it as is? it's no harm since we're not writing anything to the DB (yet). Please create new follow up PRs. This way we can minimize code conflicts.

btmccord commented 7 months ago

@btmccord can I go ahead and merge it as is? it's no harm since we're not writing anything to the DB (yet). Please create new follow up PRs. This way we can minimize code conflicts.

I guess? It feels a little odd to have in the live site since its not functional outside of a playing around / testing standpoint, but I defer to you

vnugent commented 7 months ago

Can you add a message somewhere indicating this is a WIP? Normally, I wouldn't merge unfinished work but in this case it will save us lots of merge/rebase headache.

btmccord commented 7 months ago

Yes.

I just implemented dbl click to finish, line scaling and fixed some bugs. Should I include those changes too?

vnugent commented 7 months ago

I just implemented dbl click to finish, line scaling and fixed some bugs. Should I include those changes too?

Please do!

btmccord commented 7 months ago

Okay, new commit adds

-Double click to finish line -Line scaling -'Belay/gear anchor' line termination -WIP disclaimer -Fixes a few bugs