fix(#1100): Gracefully handle runtime error for getArea query

melissapthai commented 3 months ago

What type of PR is this?(check all applicable)

[ ] refactor
[ ] feature
[x] bug fix
[ ] documentation
[ ] optimization
[ ] other

Description

Currently, if you go to an area whose uuid doesn't exist in the database, it'll throw a server error (ex: https://openbeta.io/area/f92d68ca-1b6f-5bc7-8d1f-16b3961b3cce):

And if you go to an area with an invalid uuid, it'll throw a 404 (ex: https://openbeta.io/area/asdfasdf):

I believe this is occurring because of the way Apollo Server handles validation errors (like invalid uuids) vs resolver errors (area uuid doesn't exist in database).

What this PR achieves

This PR remediates this issue by wrapping the graphql query made in getArea in a try/catch. If the query errors out, return a null area. And when rendering the area page, return notFound() for a null area.

Screenshot 2024-03-19 at 9 08 20 PM

Since the AreaPageDataProps interface was changed to accommodate for the area being nullable, I had to update a number of other places in the code that use this:

export interface AreaPageDataProps {
  area: AreaType | null
  getAreaHistory: ChangesetType[]
}

Related Issues

Issue #1100

Notes

When querying area metadata, I chose to return an empty object for non-existent areas. Let me know if that shouldn't be the case!
In src/app/(default)/editArea/[slug]/layout.tsx, I'm not super confident that it should returning an empty div for a null area.