refactor summary sections

salgadopietrini commented 2 months ago

name: Pull request about: Create a pull request title: '' labels: '' assignees: ''

What type of PR is this?(check all applicable)

[x] refactor
[ ] feature
[ ] bug fix
[ ] documentation
[ ] optimization
[ ] other

Description

Related Issues

Issue #1066

What this PR achieves

Currently, we have a common pattern where when we want to add a summary section (two columns), we create divs and add the classes that handle the grid layout. This PR encapsulates that logic into a single <Summary /> component, which accepts two children (one for each column), and also implements it in places where the old logic was implemented:

climb page
area page (through implementing it on AreaPageContainer)
crag summary

Screenshots, recordings

After refactor, should present no changes with current views:

Area page, desktop
Climb page, desktop
Area page, mobile
Climb page, mobile

Notes

I saw that crag summary used the same pattern so I used the
component there too. It should be pretty straightforward since the previous implementation was identical to the other section. However, I couldn't test changes on that section since I'm not very familiar yet so I don't how to reach that page.
For each implementation, I extracted the component corresponding to the left and right columns into their own component. Let me know if this approach is ok or if you'd prefer that pass them directly to the props of <Summary />

vercel[bot] commented 2 months ago

@salgadopietrini is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
open-tacos	✅ Ready (Inspect)	Visit Preview	Apr 22, 2024 7:52pm

vnugent commented 2 months ago

@salgadopietrini thanks for the PR. I'll look into it this weekend.

vnugent commented 2 months ago

@allcontributors add @salgadopietrini for code

allcontributors[bot] commented 2 months ago

@vnugent

I've put up a pull request to add @salgadopietrini! :tada:

OpenBeta / open-tacos