OpenBeta / open-tacos

Rock climbing route catalog (openbeta.io)
https://openbeta.io
GNU Affero General Public License v3.0
110 stars 111 forks source link

feat: create a coordinate picker modal to edit area lat lon form (#1129) #1133

Closed clintonlunn closed 1 month ago

clintonlunn commented 1 month ago

name: Pull request about: Create a pull request title: '' labels: '' assignees: ''


What type of PR is this?(check all applicable)

Description

Related Issues

Issue #1129

What this PR achieves

This pr is to add a coordinate picker within a modal that updates the Area Lat Lon form.

Screenshots, recordings

image image

https://github.com/OpenBeta/open-tacos/assets/24685932/b86edbe9-8af4-40f5-8cb7-be74e91066eb

Notes

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jun 1, 2024 3:23am
vnugent commented 1 month ago

@clintonlunn thanks for this. I'll merge it as it. Some suggestions which we can do in a follow up PR

Screenshot 2024-06-03 at 5 56 41 PM
clintonlunn commented 1 month ago

@vnugent thanks for the suggestions, and I definitely agree. I'll create some issues and would definitely like to take on those tasks.

In addition, I'd like to modify how the dialog title is styled because the title can overflow onto the X button. I think using instead of hard coding the position, using flex box would be a better approach. i have some changes to the global.css file that i made to address this, but thought it was a little out of scope of this issue.