OpenBeta / open-tacos

Rock climbing route catalog (openbeta.io)
https://openbeta.io
GNU Affero General Public License v3.0
143 stars 126 forks source link

CSV editor flagging wrong errors #875

Closed actuallyyun closed 1 month ago

actuallyyun commented 1 year ago

Steps to Reproduce

1.Create a new area 2.Mark it as a crag 3.Turn on Edit mode to add climbing routes

Screenshots

Screenshot 2023-06-15 at 18 55 28

The error it flagged is invalid grades

Expected Behavior

Should not flag errors

Current Behavior

Flag errors about the format

Browser & version

<--- Example: Firefox 102.7.0esr -->

Operating system

<--- Example: MacOS 13.2.1 -->

musoke commented 1 year ago

I have seen similar errors but haven't been able to narrow them down.

On Thu, Jun 15, 2023 at 12:00 PM Yun Ji @.***> wrote:

Steps to Reproduce

1.Create a new area 2.Mark it as a crag 3.Turn on Edit mode to add climbing routes Screenshots

[image: Screenshot 2023-06-15 at 18 55 28] https://user-images.githubusercontent.com/87448230/246170311-09873eb7-b572-4187-8208-2abe0e1890dd.png Expected Behavior

Should not flag errors Current Behavior

Flag errors about the format Browser & version

<--- Example: Firefox 102.7.0esr --> Operating system

<--- Example: MacOS 13.2.1 -->

— Reply to this email directly, view it on GitHub https://github.com/OpenBeta/open-tacos/issues/875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7ET7D53BBLAC72ABTUUM3XLMWQDANCNFSM6AAAAAAZICDKNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

musoke commented 1 year ago

@actuallyyun, what parent area did this have? (Hard to reproduce without knowing the grade context.)

actuallyyun commented 1 year ago

Hey it's Sweden/ Niemisel

vnugent commented 1 year ago

It may be related to https://github.com/OpenBeta/open-tacos/issues/853 The code doesn't know how to use grade context to validate user inputs.

musoke commented 1 year ago

Yes, creating routes in Sweden will fail for the same reason as #853.

I had seen similar failures in regions with US context, but have now narrowed down the exact cause. See https://github.com/OpenBeta/open-tacos/issues/918

musoke commented 1 month ago

Csv editor no longer exists