search

OpenBeta / openbeta-graphql

The open source rock climbing API
https://openbeta.io
GNU Affero General Public License v3.0
41 stars 32 forks source link

PR Build Pipeline broken #372

Closed l4u532 closed 11 months ago

l4u532 commented 11 months ago

@enapupe @vnugent

Something apparently broke the PR build pipeline:

Run docker/login-action@v2 Error: Username and password required

See fx: https://github.com/OpenBeta/openbeta-graphql/actions/runs/7166351784/job/19510256065?pr=371

Might be related to https://github.com/OpenBeta/openbeta-graphql/commit/e43370c451c5d05370259980884f77837ed6a0ba

enapupe commented 11 months ago

That's strange, the last main branch build pushed to dockerhub without issues. Maybe someone changed credentials afterwards? By the way, ideally we should not login to dockerhub if we are just building the container. I'm adding a patch to skip dockerhub login if it's a PR.

vnugent commented 11 months ago

It's failing because GitHub prevents contributors without write access to the repo to use/read secrets in PRs (Otherwise someone can submit a PR and print out secrets on the screen).

vnugent commented 11 months ago

Merged fix https://github.com/OpenBeta/openbeta-graphql/pull/373

@l4u532 can you please rebase your PR https://github.com/OpenBeta/openbeta-graphql/pull/371 and push again to verify the fix?