Hi, me again! I think I may have found another potential issue with this really awesome library you have created! Happy to close this one out if this is a known issue or expected behavior.
Problem
VB, VB-, VB+ are not parsed as valid grades by VScale.isType or VScale.getScore -- it doesn't recognize the string value as a valid grade.
Despite this, passing a raw score integer (e.g., 16) to VScale.getGrade will indeed return VB.
Also, parsing a Font grade and converting it to a score (e.g., Font.getScore("2b+")), then passing that returned value to vscale will also indeed return VB.
I think this may be an issue with the regex being used for parsing V Scale grades? So, potential solution would be to fix this Regex and write some tests.
musoke
commented
1 year ago
Hi, me again! I think I may have found another potential issue with this really awesome library you have created! Happy to close this one out if this is a known issue or expected behavior.
Problem
VB,VB-,VB+are not parsed as valid grades byVScale.isTypeorVScale.getScore-- it doesn't recognize the string value as a valid grade.16) toVScale.getGradewill indeed returnVB.Font.getScore("2b+")), then passing that returned value to vscale will also indeed returnVB.Stackblitz demo of the issue: here
Proposed Solution
I think this may be an issue with the regex being used for parsing V Scale grades? So, potential solution would be to fix this Regex and write some tests.