search

OpenBeta / sandbag

JS utilities for working with climbing grades
MIT License
24 stars 17 forks source link

Update "allowableConversionType" lists #175

Closed Agilulfo closed 4 weeks ago

Agilulfo commented 1 month ago

I've noticed that the list of "allowableConversionType" for the sport scales are not aligned. Scale A might have Scale B as allowed conversion but not Viceversa. It looks like this was more of an oversight than an intentional result.

I'm assuming that the purpose for this variable was to prevent conversion between bouldering and sport grades. But maybe there is more to it. Either way maybe there is some potential here for some refactoring and to apply the DRY principle.

musoke commented 1 month ago

Yes, I agree that there is much room for improvement here...