Closed Agilulfo closed 4 weeks ago
[!CAUTION] Coverage does not meet threshold Statements coverage not met for global: expected <=999999 not covered statements, but got 609
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π’ | Statements | 87.5% (+0.02% πΌ) |
609/696 |
π‘ | Branches | 67.54% | 129/191 |
π‘ | Functions | 79.87% | 119/149 |
π’ | Lines | 86.69% (+0.02% πΌ) |
560/646 |
268 tests passing in 17 suites.
Report generated by π§ͺjest coverage report action from 2ade068a84c345844207effc6f09557973b83f00
Thank you for this @Agilulfo ! This looks like a significant improvement π
Any idea what's going on with the failed coverage test? tests passed after rerunning.
@Agilulfo, I'm happy to merge as is if you want to leave the finite set of options for later.
@musoke yeah let me try to figure out the enum
Thank you @Agilulfo!
This is my attempt to fix #175
Instead of using allowableCoversionType that required to define for each scale the list of compatible scales I'm proposing to use a simpler group mechanism where a scale is part of a group of compatible scales. A scale can be converted to any other scale of the same group.
I'm not entirely sure if this assumption is correct. please let me know if this is not the case