OpenBeta / sandbag

JS utilities for working with climbing grades
MIT License
24 stars 17 forks source link

Replace allowableConversionType with conversionGroup #176

Closed Agilulfo closed 4 weeks ago

Agilulfo commented 1 month ago

This is my attempt to fix #175

Instead of using allowableCoversionType that required to define for each scale the list of compatible scales I'm proposing to use a simpler group mechanism where a scale is part of a group of compatible scales. A scale can be converted to any other scale of the same group.

I'm not entirely sure if this assumption is correct. please let me know if this is not the case

github-actions[bot] commented 1 month ago

Coverage report

[!CAUTION] Coverage does not meet threshold Statements coverage not met for global: expected <=999999 not covered statements, but got 609

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements
87.5% (+0.02% πŸ”Ό)
609/696
🟑 Branches 67.54% 129/191
🟑 Functions 79.87% 119/149
🟒 Lines
86.69% (+0.02% πŸ”Ό)
560/646

Test suite run success

268 tests passing in 17 suites.

Report generated by πŸ§ͺjest coverage report action from 2ade068a84c345844207effc6f09557973b83f00

musoke commented 1 month ago

Thank you for this @Agilulfo ! This looks like a significant improvement πŸ˜€

Any idea what's going on with the failed coverage test? tests passed after rerunning.

musoke commented 1 month ago

@Agilulfo, I'm happy to merge as is if you want to leave the finite set of options for later.

Agilulfo commented 1 month ago

@musoke yeah let me try to figure out the enum

musoke commented 4 weeks ago

Thank you @Agilulfo!