search

OpenBioML / protein-lm-scaling

Other
54 stars 15 forks source link

Epochs not changing #36

Closed talkhanz closed 10 months ago

talkhanz commented 10 months ago

num_train_epochs in protein_lm/configs/train/toy_localcsv.yaml doesnt seem to be changing the number of training epochs.

Note the epoch value is being passed in the dictionary thats printed on the terminal when we run python train.py but I dont see the training loop actually running for that number of epochs

othertea commented 10 months ago

Sorry about that! After #37 is merged, you should be able to set max_steps to -1, and then num_train_epochs should actually change the number of training epochs.

talkhanz commented 10 months ago

No need to apologize! Thankyou for the quick PR!

othertea commented 10 months ago

@talkhanz #37 has been merged! Let me know if num_train_epochs works for you now, after setting max_steps to -1.

talkhanz commented 10 months ago

looks good. thank you!