Open jmichel80 opened 1 week ago
Ooof, that's annoying. It's not even that we could load the most recent template from the ambertools
dat directory, then use Sire to rename the residues, since the charge is different too.
I guess that wouldn't matter if you're reparametrising anyway, so maybe we could just swap the template. The fiddly bit would be working out what template was included. We could probably get this by parsing the files after the failed parameterisation and following the imports.
We found this a while ago and have been trying to work out what to do about it, as the atom names that AMBER expects seem to vary depending on the context. As I recall the ambertools have a dictionary of synonyms to work around this issue, but we should probably update our code to produce the new amber names rather than the old ones.
Also, @jmichel80 you should upgrade to Flare 9 :)
I have come across something annoying with AMBER templates. So if you export a PDB from Flare version 8.0.2 in 'AMBER PDB' mode it writes ACE and NME residues with atom names consistent with those found in
In these lib files we have for ACE
for NME
However ambertools (here 23.6 from conda-forge) now seems to load lib files for all their forcefields from
In these entries ACE is specified as
And NME as
As a result trying to parameterise a protein exported from Flare
protein = BSS.Parameters.ff14SB(protein, work_dir='tmp').getMolecule()
fails with this leap error messageI wonder if there is a sensible way to automatically deal with inconsistent amber naming schemes behind the scenes when calling
protein_xtal = BSS.IO.readPDB('inputs/3STD_prep.pdb', pdb4amber=True)[0]
Note how pdb4amber doesn’t seem to catch this issue.To reproduce the issue
3STD.zip
tagging @mark-mackey-cresset as this is perhaps more a Flare bug than a BioSimSpace bug