Static and shared build releases are equal

OpenBluetoothToolbox / SimpleBLE

SimpleBLE - the all-in-one Bluetooth library for MacOS, iOS, Windows, Linux and Android.

https://www.simpleble.org

Other

697 stars 116 forks source link

Static and shared build releases are equal #208

Closed laborg closed 1 year ago

laborg commented 1 year ago

First off, thanks for publishing SimpleBLE as shared lib. I was looking forward to use them to create Julia bindings, but it turns out that they are equal to the static lib versions.

kdewald commented 1 year ago

@laborg thanks for the fix! Can you send me the link to your project so that I can send people your way?

laborg commented 1 year ago

@kdewald As soon as they are released I will tag you. The idea is to create two projects:

SimpleBLE_jll which makes the shared library available on Julia (see https://docs.binarybuilder.org/stable/jll/) and
SimpleBLE.jl a Julia package to offer a higher level abstraction for Bluetooth LE calls

laborg commented 1 year ago

@kdewald The builds for

simpleble_shared_linux-armv6.zip
simpleble_shared_linux-x86.zip still include the static libraries. Should CI automatically upload binary artifacts resulting from a merged PR or is there a manual step involved?

kdewald commented 1 year ago

@laborg There's something broken in the build process that I still need to debug, so those two will be wrong for a while longer while I figure it out.

laborg commented 1 year ago

Could it be that this is a timing problem with parallel builds?

kdewald commented 1 year ago

No, this is an architecture problem. CMake tries to link to an incorrect DBus library file. It should be somewhat straightforward to fix.

kdewald commented 1 year ago

This was fixed in v0.6.1