OpenBluetoothToolbox / SimpleBLE

SimpleBLE - the all-in-one Bluetooth library for MacOS, iOS, Windows, Linux and Android.
https://www.simpleble.org
Other
655 stars 110 forks source link

Add included services #228

Open Symbitic opened 1 year ago

Symbitic commented 1 year ago

This adds several characteristic capabilities that were missing. It also adds included_services(), but it returns it as an array of UUIDs instead of objects.

kdewald commented 1 year ago

Hey @Symbitic, thanks a lot for these contributions!

In order to help me speed up the review, testing and merging of your features, could you split the changes of this MR into smaller MRs that I can individually try out?

Top of my mind, the separation I would make is:

I hope this can help make the addition of features much faster and easier to test :D

Symbitic commented 1 year ago

Sure. I'll extract included services and power state from this and leave it as just capabilities.

Symbitic commented 1 year ago

I stand corrected: I leave this PR as included services and extracted capabilities and power state to separate PRs.

Symbitic commented 4 months ago

@kdewald any updates?

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.