search

OpenBoard-org / OpenBoard

OpenBoard is a cross-platform interactive whiteboard application intended for use in a classroom setting.
https://openboard.ch/
GNU General Public License v3.0
2.4k stars 429 forks source link

Remove MD5 hashing from UBFileSystemUtils #1019

Closed Vekhir closed 3 months ago

Vekhir commented 5 months ago

The functions MD5_Init, MD5_Update, MD5_Final are deprecated in OpenSSL 3.0. This leads to warnings during compilation.

Use EVP_Q_digest instead. Edit: Since the utility functions md5 and md5InHex are not used anywhere, just remove them.

letsfindaway commented 5 months ago

I have another proposal: The MD5 functions can safely be removed from UBFileSystemUtils as nobody is using them. And if there would be some future use, then QCryptographicHash already provides all this functionality.

Vekhir commented 5 months ago

True. I've checked out how the widgets sums are calculated and they use QCryptographicHash.

I've updated the commit to just remove those functions.

letsfindaway commented 5 months ago

Please remove them also from the header file.

Vekhir commented 4 months ago

Done