OpenBoard-org / OpenBoard

OpenBoard is a cross-platform interactive whiteboard application intended for use in a classroom setting.
https://openboard.ch/
GNU General Public License v3.0
2.4k stars 429 forks source link

refactor: Remove usage of QT_IMPLICIT_QCHAR_CONSTRUCTION #1058

Closed Vekhir closed 2 months ago

Vekhir commented 2 months ago

Since Qt 6.0, the macro QT_IMPLICIT_QCHAR_CONSTRUCTION was necessary to allow implicit conversion from int to QChar. Qt 6.8 removes this macro, making the default behaviour mandatory, i.e. call the QChar constructor with an int to get a QChar.

This affects Linux and Windows who make use of this macro; removing the macro reverts to the default since 6.0, so this change is fully backwards compatible. Qt5 never had the macro (it was introduced to ease the transition from Qt5 to Qt6), therefore nothing changes there either.

Tested on Arch Linux with Qt 6.7.2, 6.8beta3, and 5.15.14.

Fixes #1055