OpenBoard-org / OpenBoard

OpenBoard is a cross-platform interactive whiteboard application intended for use in a classroom setting.
https://openboard.ch/
GNU General Public License v3.0
2.4k stars 429 forks source link

[Bug] New icon for **snap to grid** feature looks like a little bit different #1118

Closed sebojolais closed 1 month ago

sebojolais commented 1 month ago

Describe the bug

The new icon for snap to grid feature looks like a little bit different compared to others. Have a look below : image The differences are located on the white circle for the enable state:

The icon works fine. Really easy to understand. It is meaningful. :+1: This bug report has a low priority because it is a detail if we want to be exigent on the look and feel of OpenBoard.

To Reproduce

Expected behavior

The icon should looks like the others Icons for the size and the transparency.

Context

letsfindaway commented 1 month ago

First of all: thanks for your sharp eye ;) I looked into the SVG and in fact, while the semi-transparent circle has a radius of the full width of the icon, it is a little bit smaller for the magnet. This should be easy to solve.

But also please be aware that the stylus palette is currently mostly built from PNG images. And especially the keyboard next to the magnet is PNG and has a different style for the semi-transparent circle. However there are also SVG images available in the resources/images/stylusPalette folder at least for some of the buttons (eraser, marker, pen).

So in fact it would be good to look into all the icons and adjust their style.

sebojolais commented 1 month ago

Thank you for your answer. It is great if the size of the white circle could be fixed. The transparency is less important in my POW. Thank you so much for the PR #1121. :+1:

letsfindaway commented 1 month ago

Closing as #1121 was merged