OpenBoard-org / OpenBoard

OpenBoard is a cross-platform interactive whiteboard application intended for use in a classroom setting.
https://openboard.ch/
GNU General Public License v3.0
2.41k stars 431 forks source link

[Feature Request] Rotate the page #1136

Open sebojolais opened 1 month ago

sebojolais commented 1 month ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like For the 2 problems, the solution could be a 90° rotation of the page.

Where we can imagine the feature? Currently we can arrange pages in the thumbnail left dock. On each page, there are 2 button: for deleting or duplicating the page. We can add one button to rotate the page. Each action on the button throws a 90° rotation in clockwise. So by 1, 2 or 3 clicks, we manage the 3 kinds of rotation. Have a look below for a sketchup: Screenshot_20241006_150122

Describe alternatives you've considered

Additional context Could you give a feedback like a go/no-go because I propose to implement it but I do not want to spent energy if it could not be accepted.

letsfindaway commented 1 month ago

I also have something like this on my list since years (https://github.com/letsfindaway/OpenBoard/issues/8) but did not work further. However I would support such a feature and attaching it to the thumbnails view seems to be a good idea to me.

sebojolais commented 1 month ago

Hi Martin, Thank you for your answer and your support. Just a detail: Your issue speaks about rotation of the background object and it was also my initial idea. But after sometime, I switched the feature to rotate the page and not only background object because:

letsfindaway commented 1 month ago

Just some comments for rotating the full page:

This does however not work when your selection contains any item which cannot be rotated.

sebojolais commented 1 month ago

Yes, we have to keep in mind issues with unrotatable objects.

In other hand, if the page is not empty, rotate only the background object and not the others could sound strange and not user-friendly.

Maybe an intermediate solution could be:

We could show a warning message if there are some unrotatable objects to say "Some objects could not be rotated."

letsfindaway commented 1 month ago

In fact, I don't yet see a convincing use case that would justify introducing a new feature for rotating the entire page.

Rotating the background is currently not possible. In my opinion, this justifies a new feature, as this is sometimes necessary. Examples are PDF files with incorrect page orientation or photos with missing or incorrect information about their orientation.

However, the workflow I described already exists for the items on the page: group items and rotate the group. Some rework may still be necessary in individual cases, but it is also easy to move or scale the group.

Rotating the background and items separately may be a little more complex. However, I think this is perfectly acceptable for the few cases where it is needed.

sebojolais commented 1 month ago

I agree with your arguments.

If we want to rotate the background and not the page:

I am sorry because just able to say where I can not imagine this feature but no idea where it could be at the right place...

Maybe we can close this ticket rotate the page and open another called rotate background object ?

kaamui commented 1 month ago

Hi @sebojolais !

Sorry for my late reply. There are things planned internally about this, but it somehow embraces more things than just rotating the PDF, even if the initial goal was that. One of the issue you have (and that I had too) on "where to put this feature ?" should be solved with the potential changes around page Size rework.

I created a Project, very basic as a first step, to share with you and others some internal informations, to help on this. I'll replace some of the items by opened discussions when I find time for it).

Please forgive the temporary raw state of it : https://github.com/orgs/OpenBoard-org/projects/1

sebojolais commented 1 month ago

Hi @kaamui , Thank you for your answer. Nice to see a front-end of your internal topics :+1: great job!

letsfindaway commented 1 month ago

I also welcome this project page very much. Thank you! I'm just missing the flexible background patterns from this list.

kaamui commented 3 weeks ago

I'm just missing the flexible background patterns from this list.

Fixed