OpenBoard-org / OpenBoard

OpenBoard is a cross-platform interactive whiteboard application intended for use in a classroom setting.
https://openboard.ch/
GNU General Public License v3.0
2.24k stars 412 forks source link

Correct installation of files according to FHS #638

Open neurofreak-alt opened 2 years ago

neurofreak-alt commented 2 years ago

Greetings! I would like to see the structure of the project installed in the %buildroot brought closer to the FHS ( https://wiki.linuxfoundation.org/lsb/fhs) used in linux. Right now everything is built and installed in the ../product/release directory. I would like to see the configuration files in ../build/release/etc/OpenBoard, binary files in ..build/release/usr/bin, resources in ../build/release/usr/share/OpenBoard Will this happen in the future?

letsfindaway commented 2 years ago

Yes, I would also like to see that.

Currently in some places a set of patches is used to bring OpenBoard closer to the FHS layout. I'm also using patches for my openSUSE builds of OpenBoard. i think especially patch 0002-Install-to-correct-directories-on-linux.patch and 0004-Use-QStandardPaths-to-locate-resources.patch are important. I don't know exactly who started to create these patches, but might be they originate from the Flathub builds.

The resulting layout is still not perfect, but at least

/usr/share/OpenBoard/etc is still a mess which would need some cleanup, but it is better than installing to /opt.

Note however that the deployment of OpenBoard at the schools in Geneva might have additional and contradicting requirements. I don't know, but it might be that it wouldn't be so easy for them to move to another directory layout. So this needs probably to be discussed and a migration strategy is needed.

jbruechert commented 2 years ago

The patches used for flathub or just a git format-patch upstream/1.7-dev from my repository on GitLab, where I'm maintaining the patches for the flatpak packaging for each branch that I'm interested in in git. If you want we can use that (or a new repository) and maintain these patches together.

EDIT: To be exact, the 1.7-dev branch is what the next flatpak release will be based on.

letsfindaway commented 2 years ago

The patches used for flathub or just a git format-patch upstream/1.7-dev from my repository on GitLab, where I'm maintaining the patches for the flatpak packaging for each branch that I'm interested in in git. If you want we can use that (or a new repository) and maintain these patches together.

EDIT: To be exact, the 1.7-dev branch is what the next flatpak release will be based on.

Good idea! My wish list for further evolution of these patches would be:

But up to now I was merely using these patches and have not looked much deeper into them. Thanks for providing them!

letsfindaway commented 5 months ago

After merging #830, a cmake based build system creating a FHS compliant layout is now available in the dev branch. See https://github.com/letsfindaway/OpenBoard/wiki/CMake-Build-System for usage instructions.