search

OpenBookPrices / country-data

Country related data such as ISO codes, currencies etc
MIT License
515 stars 165 forks source link

overhauled the regions to fill in the continents and regions #22

Closed iancrowther closed 9 years ago

iancrowther commented 9 years ago

resolves #14

evdb commented 9 years ago

This all looks good - bar a few comments that I've made inline. Main concern is the regions.australia which I think should be regions.australasia but might well be wrong.

Thanks for the changes and additions - I know it can be a very time consuming thing to do :)

iancrowther commented 9 years ago

ok - I had it as australasia originally, having been deep in wikipedia got the perception that oceania was a better fit, however its 50/50.

Do you still want the changes?

and yes, its much bigger than I first thought :-)

have tests now btw to sync the countries json & regions.js

evdb commented 9 years ago

The tests would be great - always keen to have tests :)

Not sure which of Australasia or Oceania are better. It seems that the exact definitions are rather vague... I think change it to Australasia as that seems most precise.

iancrowther commented 9 years ago

np - will do

iancrowther commented 9 years ago

Hey @evdb

I took a look at the United Nations decomposition of regions and it turns out they refer to the region as oceania.

As much as I love Wikipedia, I think the UN is most internationally recognised.

Ian

iancrowther commented 9 years ago

closing to push updates, clensing and tests