Neutralize country name

OpenBookPrices / country-data

Country related data such as ISO codes, currencies etc

MIT License

513 stars 165 forks source link

Neutralize country name #39

Closed azaitw closed 9 years ago

azaitw commented 9 years ago

Use less ambiguous name.

evdb commented 9 years ago

I'm not really sure what the political ramifications of this change are...

However as "Taiwan, Province Of China" does not appear on the Taiwan Wikipedia page it seems to be a sensible change.

azaitw commented 9 years ago

Yup, coding-wise, it's easier to implement shipping and currency logic, since Taiwan use different country destination and currency to China. This change will avoid potential problem of confusion.