search

OpenBookPrices / country-data

Country related data such as ISO codes, currencies etc
MIT License
515 stars 165 forks source link

United Kingdom listed twice (but different country codes) #72

Open gbruins opened 7 years ago

gbruins commented 7 years ago

United Kingdom,GB,GBR,,+44,GBP,🇬🇧,GBR,"eng,cor,gle,gla,cym",assigned United Kingdom,UK,,.uk,,GBP,,,"eng,cor,gle,gla,cym",reserved

Also, I believe the official name is "United Kingdom of Great Britain". Perhaps you can assign this name to the "GB" country code, so users who search for "Great Britain" will still get a result.

stclairdaniel commented 6 years ago

I would love to see this fixed as well - I have to splice the countries array every time I use it.

freddieduffield commented 5 years ago

@stclairdaniel Would you be able to share your work around for this issue? Thanks

gbruins-notours commented 5 years ago

@FrederickFoxxx This project seems abandoned. You might be better off looking for another library, perhaps country-json

freddieduffield commented 5 years ago

@gbruins Thanks I'll check it out

stclairdaniel commented 5 years ago

@FrederickFoxxx I just spliced the list to take out the duplicate: countries.splice(265, 1)

yashutanna commented 4 years ago

as far as my research here goes, also referenced here: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#UK

UK has been reserved by the united Kingdom lest another country uses it as to avoid ambiguity. the official ISO alpha 2 code is however GB.

as such, i would defer to keeping the library aligned to ISO 2 codes as opposed to including reservations. im happy to open up a PR to remove UK if everyone here agrees?