search

OpenBracketsCH / defikarte.ch-app

The repo for the mobile app of defikarte.ch
MIT License
10 stars 3 forks source link

Add defibrillators with valid `opening_hours` #162

Closed habi closed 11 months ago

habi commented 1 year ago

Version 1 of this Defibrillator was added with free-text opening hours. I think it would be cool if the opening_hours tag is added correctly/valid.

Maybe the Defikarte-App could introduce an opening hours setter, like Vespucci, Every Door or StreetComplete.

habi commented 1 year ago

Found when taking care of https://www.openstreetmap.org/note/3614889

chnuessli commented 1 year ago

We'll check on that. Thank you

elektrolytmangel commented 1 year ago

We have an opening_hours validation, I will check on that and why it was accepted. I think the library we use, allows multiple languages and is probably not that strict. The idea for an editor is great, we check that, thanks for the support!

chnuessli commented 11 months ago

Hi @elektrolytmangel as discussed on the CH Mailing list, the issue still activ. Have you got a solution? The App User is at the moment the leader in the Project of the Month from Swiss OSM and the eyes are on us :)

elektrolytmangel commented 11 months ago

Thanks for the reminder. I fixed the issue. Now the value from the 1st version of the defibrillator is not accepted any more. We also show a message which helps the user to fix the errors/warnings. Deployment on android and ios is waiting. Web see: PR

elektrolytmangel commented 11 months ago

Apps are published to Google Play Store and Apple App Store.