OpenBricks / openbricks

Embedded Linux Framework
http://www.geexbox.org/
GNU General Public License v2.0
82 stars 42 forks source link

geexbox-kodi-imx6-cuboxi: ass subtitles not working - dependancy problem #52

Closed djack42 closed 8 years ago

djack42 commented 9 years ago

Hi, In the geexbox-kodi-imx6-cuboxi snaphot, when playing a mkv file with embedded ass subtitles, no subtitles are displayed, srt subtitles are working though. That problem has been seen on the last 2 builds :

Here is the log when kodi plays the mkv : https://gist.github.com/djack42/d62b1beca965318dc04f#file-geexbox-kodi-libass-log

The problem seems to be an incompatible libass, I tried to force a reinstall of that package but nothing changed and according to http://upstream.rosalinux.ru/compat_reports/libass/0.10.0_to_0.10.1/abi_compat_report.html, 1 symbol have been added, and it the one required :(

I'm really happy to see kodi on my hummingboard with geexbox by the way. Keep up the good work :)

djack42 commented 9 years ago

I couldn't build the entire distro (my first time) but I managed to build the new version of libass, replaced it on my current geexbox install and ssa subtitles are finaly working.

I guess you could merge into master now, the buildbot is going to rebuild kodi-imx6 soon. thx.

btw where can I have support to build a fork of devel ? I did tried on a fresh ubuntu x64, did ./script/loadcfg geexbox-kodi-imx6-cuboxi, then make but it was not going all the way until I tried make doc first (xsltproc failed somehow). thx again

tomlohave commented 9 years ago

Le 03/08/2015 21:35, djack42 a écrit :

I couldn't build the entire distro (my first time) but I managed to build the new version of libass, replaced it on my current geexbox install and ssa subtitles are finaly working.

I guess you could merge into master now, the buildbot is going to rebuild kodi-imx6 soon. thx.

We can cheery pick this commit, but we have others commits that can be problematic in devel branch..

btw where can I have support to build a fork of devel ? Here I did tried on a fresh ubuntu x64, did ./script/loadcfg geexbox-kodi-imx6-cuboxi,

./scripts/loadcfg geexbox-kodi-imx6-cuboxi

then make but it was not going all the way until I tried make doc first (xsltproc failed somehow). Can you post the exact problem ? you did "make" and nothing or did you get something on the terminal ? thx again

Cheers !

— Reply to this email directly or view it on GitHub https://github.com/OpenBricks/openbricks/issues/52#issuecomment-127381726.

www.geexbox.org mailto:tomlohave@openbricks.org

djack42 commented 9 years ago

I'm sorry, I didn't log the first build output, but I can explain step by step what I did to continue the build at that point (I'm still building)

  1. setting up a fresh ubuntu 15.04 x64 vm in virtualbox
  2. forked openbricks devel branch
  3. "./scripts/loadcfg geexbox-kodi-imx6-cuboxi" I had to enable some packages manually at the end (the one recently added)
  4. "make", at that point, it was building for a while and while building libxslt (or libexslt idk), a step with xsltproc failed trying to install some doc. just after the line "Making install in doc", there was the following error : recipe for target 'xsltproc.1' failed
  5. after googling i without result, I tried "make doc"
  6. This process downloaded, build and installed more than 1Go of doc tools on my system. . I did "make" again, it is still building but I succeeded building that lib I think that there is a tool installed by "make doc" required to build but not automatically installed. leading to that error.
  7. while building kodi isengard 15, It failed because java was not found. https://gist.github.com/djack42/235d02833c9a2be18165#file-kodi-build-failed-java-not-found-log "apt-get install openjdk-7-jre" did the trick, but it could have asked to install it first like some other tools. At this point, kodi forums are helping...
  8. kodi failed to build again be cause some xml file is missing https://gist.github.com/djack42/235d02833c9a2be18165#file-kodi-build-failed-addonmodulexbmc-xml-not-found-log in fact, it's in the path : build.xmluboxi.eglibc, the '.c' of .cuboxi have been replaced by '.xml' in the following line : (xbmc/codegenerator.mk, rule codegenerated: does not protect the path from substitution, making the build impossible in /tmp/openbricks/build/build.cuboxi.eglibc/)

    Unable to open file /tmp/openbricks/build/build.xmluboxi.eglibc/kodi-isengard-15.1-rc1-r2beaf49/xbmc/interfaces/python/generated/AddonModuleXbmc.xml: No such file or directory.

  9. Still trying to solve that, how the buildbot did it ?
djack42 commented 9 years ago

I found out for the 8. it's a bug in the swig tool used in the build of kodi, replacing any ".c" by ".xml" in the full filename given as output file. In xbmc/codegenerator.mk, the following rule :

$(GENDIR)/%.xml: %.i $(SWIG) $(JAVA) $(GENERATE_DEPS) mkdir -p $(GENDIR) $(SWIG) -w401 -c++ -o $@ -xml -I$(TOPDIR)/xbmc -xmllang python $<

replaced by the following is working :

SWIG_TEMP_OUTPUT_XML = /tmp/swig_output.xml $(GENDIR)/%.xml: %.i $(SWIG) $(JAVA) $(GENERATE_DEPS) mkdir -p $(GENDIR) $(SWIG) -w401 -c++ -o $(SWIG_TEMP_OUTPUT_XML) -xml -I$(TOPDIR)/xbmc -xmllang python $< mv $(SWIG_TEMP_OUTPUT_XML) $@

I double checked with a filename containing some ".c" :

SWIG_TEMP_OUTPUTXML = /tmp/swig.cou.ctput.xml and I saw : ls /tmp/swig* /tmp/swig.xmlou.xmltput.xml

The problem is here : https://github.com/swig/swig/blob/master/Source/Modules/xml.cxx#L84 Ihave to create an issue on the github of swig.

tomlohave commented 8 years ago

Can't reproduce this, feel free to re-open in case you still have the problem