update `נסגר להגשות, ממתין לפרסום תוצאות` behaviour

[noamoss]

Following this item: https://next.obudget.org/i/tenders/central/645818/technology-cloud_tender

We should:

1. change the ambiguous פורסם וממתין לתוצאות label (in source) to appear the same in obudget (currently it is translated to נסגר להגשות, ממתין לפרסום תוצאות)
2. prevent פורסם וממתין לתוצאות from setting the item's status: it should not set the item status to סגור - even though it might mean that in some scenarios. Instead, when this label appears in the חשכ"ל items, the due date should define the item's status.

[akariv]

The fix here is to merely change the translations in the tenders spreadsheet to the correct ones. The email does not really care about the textual status, but looks at the publication/due dates.

@Noamoss noamoss@gmail.com

On Fri, Feb 7, 2020 at 12:41 PM noamoss notifications@github.com wrote:

Assigned #463 https://github.com/OpenBudget/BudgetKey/issues/463 to @akariv https://github.com/akariv.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OpenBudget/BudgetKey/issues/463?email_source=notifications&email_token=AACAY5LOYBLEKPM2H4Q2AWTRBU3FHA5CNFSM4KRMKAGKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWPLJOEI#event-3017185041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5NO26WTODYKVFRUWZ3RBU3FHANCNFSM4KRMKAGA .

[noamoss]

@akariv

The fix here is to merely change the translations in the tenders spreadsheet to the correct ones.

done lines, 14-17.

The email does not really care about the textual status but looks at the publication/due dates.

but the status filter on site does. What/how should it be defined in the simple decision field then (left it empty for now)?

[akariv]

I think this is פתוח

On Fri, Feb 7, 2020 at 2:08 PM noamoss notifications@github.com wrote:

@akariv https://github.com/akariv

The fix here is to merely change the translations in the tenders spreadsheet to the correct ones.

done https://docs.google.com/spreadsheets/d/1JkZooBwoxKPlrXWWwUtNHLMdxc-iG0n5tdGZ23I8fYY/edit?usp=sharing lines, 14-17.

The email does not really care about the textual status but looks at the publication/due dates.

but the status filter on site does. What/how should it be defined in the simple decision field then (left it empty for now)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenBudget/BudgetKey/issues/463?email_source=notifications&email_token=AACAY5NX2OBHNGXXAL4JVA3RBVFKXA5CNFSM4KRMKAGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELCWYCQ#issuecomment-583363594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5PC4YGFXTTAGUMNKLLRBVFKXANCNFSM4KRMKAGA .

[noamoss]

@akariv not always. This is how I changed it:

I guess it will prevent errors like this issue but will keep closing tenders with documented transfers. If it seems ok, please update here when you pushed the update to the site.

[noamoss]

checked and approved on live