OpenBudget / BudgetKey

Opening the Israeli Budget!
https://next.obudget.org
48 stars 15 forks source link

supports criteria due date is scraped but not displayed #469

Closed noamoss closed 4 years ago

noamoss commented 4 years ago

while checking https://github.com/OpenBudget/BudgetKey/issues/408, found this problem. See for example this item: https://next.obudget.org/i/support_criteria/support_criteria/153722/ac3b7663-6cc1-41df-9292-dd0011aff968?li=1&theme=socialmap

image

image

This item was updated with a new due date, we know it (see the red message) but do not display it in the item body.

noamoss commented 4 years ago

another quick example: https://next.obudget.org/i/support_criteria/support_criteria/17293/2dcdda50-4a29-437e-90e0-c2195c497997?li=4&theme=socialmap

akariv commented 4 years ago

we decided to change the type of these to 'call for bids', and keep only the pure support criteria documents (from guidestar) in the support criteria category. as such, they do not have a claim date.

On Tue, Feb 11, 2020 at 11:37 PM noamoss notifications@github.com wrote:

another quick example: https://next.obudget.org/i/support_criteria/support_criteria/17293/2dcdda50-4a29-437e-90e0-c2195c497997?li=4&theme=socialmap

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OpenBudget/BudgetKey/issues/469?email_source=notifications&email_token=AACAY5MAEKHBWTYA3NRSHATRCMLCDA5CNFSM4KTJJMAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELOFNAA#issuecomment-584865408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5M3SNFXP6HM7O6HDRDRCMLCDANCNFSM4KTJJMAA .

akariv commented 4 years ago

@noamoss This was applied, you should not be able to find any items with claim dates in the support criteria category

noamoss commented 4 years ago

@akariv I think the original problem remains after applying this solution. See the example item above: we know that a request to be submitted will not be checked:

image

we can scrape this data and show it - and therefore let the user know about the due date? What do I miss here?

// cc @maryLoi

akariv commented 4 years ago

This is the actual item - the one you linked above is not accessible via search any more.

https://next.obudget.org/i/calls_for_bids/call_for_bids/153722/ac3b7663-6cc1-41df-9292-dd0011aff968?li=0

On Sat, Feb 22, 2020 at 10:53 AM noamoss notifications@github.com wrote:

Assigned #469 https://github.com/OpenBudget/BudgetKey/issues/469 to @akariv https://github.com/akariv.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OpenBudget/BudgetKey/issues/469?email_source=notifications&email_token=AACAY5I4LVUZX5WJHZ5CD73REDRYJA5CNFSM4KTJJMAKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW2FYKCY#event-3062596875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5MIC65AR5M3NNSZPR3REDRYJANCNFSM4KTJJMAA .