OpenBudget / BudgetKey

Opening the Israeli Budget!
https://next.obudget.org
49 stars 15 forks source link

fix תמיכות ומענקים type label #475

Open noamoss opened 4 years ago

noamoss commented 4 years ago

We should not use label to describe the category, but the relevant item. Therefore, I think we should

  1. fix this label into "תמיכה או מענק"
  2. fix the label icon to include both terms: a. I already added the relevant explaination to the tooltips file b. still need to fix the i icon location, to appear at the end of the label text

for example https://next.obudget.org/i/calls_for_bids/call_for_bids/121579/bc4b7d92-4ca1-4779-9bc6-5db37d44a9c8?li=19&theme=socialmap

image


After asking for professional advice, it sounds like the main difference between תמיכה and מענק are the legal source (the law) and that מענקים are dedicated to a list of predefined activity fields, but in practice, מענקים are considered to be מענקים subtype. In other words, we should also consider turning all "תמיכה" or "תמיכות" constants into "תמיכה או מענק" and "תמיכות או מענקים", but I am not sure about it yet.