search

OpenBudget / BudgetKey

Opening the Israeli Budget!
https://next.obudget.org
49 stars 15 forks source link

Broken image in weekly notification mail #506

Open noamoss opened 4 years ago

noamoss commented 4 years ago

Screenshot_2020-10-17-10-24-02-102_com.google.android.gm.jpg

noamoss commented 4 years ago

One of the broken images links: https://next.obudget.org/i/tenders/office/653603/15/9.2020

akariv commented 4 years ago

Can you forward me the email?

On Sat, Oct 17, 2020 at 10:27 AM noamoss notifications@github.com wrote:

One of the broken images links: https://next.obudget.org/i/tenders/office/653603/15/9.2020

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/OpenBudget/BudgetKey/issues/506#issuecomment-710766521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5L5NZ34XYQZO6BTFOLSLFBOBANCNFSM4SUFXIHQ .

noamoss commented 4 years ago

@akariv while looking at it again, the problem did not reoccur, so I guess no point in forwarding it. Probably a slow connection with timeout or a temporary glitch.

Anyhow, I would suggest using relevant techniques, as a textual placeholder ("פריט לתצוגה") for these rare cases.

(please notice I had 5 broken images icons in the mail at a first glance).

What do you think?

akariv commented 4 years ago

Yes, adding an alt attribute is a good idea, also for accessibility reasons.

On Sat, Oct 17, 2020, 18:44 noamoss notifications@github.com wrote:

@akariv https://github.com/akariv while looking at it again, the problem did not reoccur, so I guess no point in forwarding it. Probably a slow connection with timeout or a temporary glitch.

Anyhow, I would suggest using relevant techniques https://exceptionshub.com/how-to-hide-image-broken-icon-using-only-csshtml-without-js.html, as a textual placeholder ("פריט לתצוגה") for these rare cases.

(please notice I had 5 broken images icons in the mail at a first glance).

What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenBudget/BudgetKey/issues/506#issuecomment-711032438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5KE7B5ZK4YAXV24XUDSLG3VVANCNFSM4SUFXIHQ .