OpenBudget / open-budget-frontend

Israeli budget web apps
19 stars 32 forks source link

Reduce the need of webpack alias #343

Closed Bnaya closed 8 years ago

Bnaya commented 8 years ago

Our project depends on alias for things like:

"team":                 "scripts/team",

heritage from the requirejs config We should change the references of the modules directly to the module location and remove the alias.

            "team":                 "scripts/team",
            "url_scheme":           "scripts/url_scheme",
            "main_page_tabs":       "scripts/main_page_tabs",
            "models":               "scripts/models",
            "spinner":              "scripts/spinner",
            "combined_history":     "scripts/combined_history",
            "history_widget":       "scripts/history_widget",
            "indepth_widget":       "scripts/indepth_widget",
            "views":                "scripts/views",
            "detailed_history":     "scripts/detailed_history",
            "single_changegroup":   "scripts/single_changegroup",
            "breadcrumb_header":    "scripts/breadcrumb_header",
            "analysis_header":      "scripts/analysis_header",
            "bubble_chart":         "scripts/bubble_chart",
            "main_page_vis":        "scripts/main_page_vis",
            "support_list":         "scripts/support_list",
            "support_pivot_table":  "scripts/support_pivot_table",
            "spending_list":        "scripts/spending_list",
            "spending_pivot_table": "scripts/spending_pivot_table",
            "searchbar":            "scripts/searchbar",
            "subscribe":            "scripts/subscribe",
            "hello":                "scripts/hello",
            "training":             "scripts/training",
            "budget_view":           "scripts/budget_view",

But not this one:

            "Hasadna/oBudget":       "scripts/Hasadna/oBudget"

Is different, it maps an entire directory and not a specific file. Also if there's orphan files remove them (scripts/views ?)