Support Swift_Image when adding attachments

OpenBuildings / postmark

Postmark transport for Swift Mailer

https://github.com/OpenBuildings/postmark

BSD 3-Clause "New" or "Revised" License

16 stars 8 forks source link

Support Swift_Image when adding attachments #19

Closed leevigraham closed 6 years ago

leevigraham commented 9 years ago

Hi guys,

I'm comparing a Postmark Transport I wrote a while ago with your implementation and it looks like you haven't considered Swift_Image attachments: https://github.com/OpenBuildings/postmark/blob/master/src/Swift_Transport_PostmarkTransport.php#L165

I haven't tested your implementation yet so I could be wrong but I thought I would throw it out there.

http://swiftmailer.org/docs/messages.html#embedding-inline-media-files

Cheers Leevi

hkdobrev commented 9 years ago

@leevigraham Thanks for that! We would look into it. As far as I know we have used our implementation only with PDF attachments so we haven't tested images either.

hkdobrev commented 6 years ago

Embedded images are supported. Tests have been added in #41.

leevigraham commented 6 years ago

Forgot about this one 👍