search

OpenBuildings / postmark

Postmark transport for Swift Mailer
https://github.com/OpenBuildings/postmark
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

Improve travis & phpunit #3

Closed piotrantosik closed 10 years ago

piotrantosik commented 10 years ago
ivank commented 10 years ago

10x

ivank commented 10 years ago

This conflicts with you previous PR though ....

piotrantosik commented 10 years ago

rebased, thanks for merging

hkdobrev commented 10 years ago

@piotrantosik Why the uppercase in the Tests folder btw?

piotrantosik commented 10 years ago

this is a convention in symfony and many other php lib, but you're right - it is not necessary

hkdobrev commented 10 years ago

@piotrantosik Thanks! We are trying to follow Symfony coding standards and Symfony naming conventions with future libraries as @ivank metnioned. But this convention is not listed there.

The reason Symfony components use Tests is because this folder is part of their namespacing structure. E.g.: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/ClassLoader/Tests/ApcUniversalClassLoaderTest.php

:beers: