search

OpenBuildings / postmark

Postmark transport for Swift Mailer
https://github.com/OpenBuildings/postmark
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

remove composer.lock #5

Closed piotrantosik closed 9 years ago

piotrantosik commented 9 years ago

composer.lock is not required for library, currently phpunit use swiftmailer 5.0.3 saved in composer.lock

hkdobrev commented 9 years ago

From the Composer documentation on libraries:

Lock File

For your library you may commit the composer.lock file if you want to. This can help your team to always test against the same dependency versions. However, this lock file will not have any effect on other projects that depend on it. It only has an effect on the main project.

https://getcomposer.org/doc/02-libraries.md#lock-file

It is useful when multiple developers work on the same library. It also cause no harm to people who use the library.

piotrantosik commented 9 years ago

basically as but it is all about testing - see for example latest travis build: https://travis-ci.org/OpenBuildings/postmark/jobs/30637069 (Installing swiftmailer / swiftmailer (v5.2.1)) and https://travis-ci.org/OpenBuildings/postmark/jobs/30635780 (Installing swiftmailer / swiftmailer (v5.0.3)) goal of the test is to test the latest available but supported versions of required dependency. another option is use a composer update instead of install (https://github.com/OpenBuildings/postmark/blob/master/.travis.yml # L16)

hkdobrev commented 9 years ago

@piotrantosik See this comment: https://github.com/OpenBuildings/swiftmailer-css-inliner/pull/6#issuecomment-50740297