Add option to Disable Autostart on boot.

[zirkeltraining]

(with OB MD v.1.0.101 on Mac OS 10.13.6 - haven't tested it elsewhere)

Closing the window with the "x" Button or choosing "Quit" from the file menu does not end the application. Instead it remains active in the dock at all times. Must use "force quit" to get rid of it, which feels ... dirty. This should not be the default behaviour. Also, there seems to be no config option to avoid the app to start upon boot. That's also not what a nice driver should do, isn't it? Please include an option to easily kill the driver and to avoid it coming back up on restart.

[petervanderwalt]

There is a Quit (: Right click on the Dock icon

Regarding the other behavior: 1) The idea here is that it sits in the background similar to a "printer driver" (Think HP, Epson etc) - but due to cross platform nature its not entirely as transparent. On windows it hides nicely out of the way in the systray. On Mac the "dock" is as close to the systray as we have. On linux it hides in the tray too (even on raspberry pi's pixel desktop) 2) Being always-on is needed for the integration with cam.openbuilds.com and upcoming projects (Justified: The browser cannot launch applications, so we cannot run the driver for you. If its already running we can interact with it which is what we need) 3) This is pretty standard industry behaviour (see Cricut's agent, EaselDriver, etc) - Doing it this way helps those users who are not IT professionals - they dont need to worry, it just works. They dont need to remember to run something first, or start it or whatever, its just always there.

I'll consider adding an option to disable autostart - will keep issue tagged and close once implemented.

[petervanderwalt]

Refer to https://github.com/electron/electron/issues/10880 -> Upstream fix needed first

[petervanderwalt]

I'll also checkout https://stackoverflow.com/questions/35008347/electron-close-w-x-vs-right-click-dock-and-quit to catch the Mac native "Quit" menu (Mac user count is much lower than windows, so its OS specific quirks arent all handled yet)

[petervanderwalt]

I've increased the forcefulness of "quitting" in the app, but my OSX VM is broken (no Mac to test on) Version 1.0.112 will be available later today (compiling now) - if you want to give it some testing, please report back- no guarantees file->quit works as I couldnt test it, but the hope is it does now. Clicking X button should still Minimise to Dock (if the code works like it should, again, couldnt test)

Regarding opting out of the autostarting, still waiting for a fix in https://github.com/electron/electron/issues/10880 - the problem is still upstream at the Electron project - once thats fixed, only then can I do something on our side (: - thanks for the patience

[zirkeltraining]

I appreciate your thorough response, here's what I find on the mac with 1.0.112:

• File->Quit or apple-Q or right-clicking the dock icon and using "Quit" still only closes the drivers' window.
• but right-clicking the dock icon and using "Quit Machine driver" seems to work fine (as before; I only hadn't noticed this menu)
• the dock context menu "options->open at login" is not checked when the menu is opened for the first time after a machine boot, although the driver was autostarted. That's probably just an initialisation missing. After opening the menu for the second time, it's checked.
• however, the checkmark on "open at login" cannot be removed - it remains on all the time.
• during autostart, apparently the driver window opens with no controls at first, then takes multiple seconds to become responsive and redrawn.

summary:

• there are two quit options in the dock menu, but only one does what i'd expect
• autostart can never be turned off at the moment. must quit the driver manually after each boot to get rid of it.

[petervanderwalt]

Re "open at login" and removing from autostart, remember its upstream from us, see https://github.com/electron/electron/issues/10880 - has since been fixed in https://github.com/electron/electron/pull/15010 - but since Electron 4 is almost out of beta (We're not on 4 yet) it might be better to hold off till we go to 4.x and then implement it using the new API

You found the right menu though so thats the way for now.
The "Quit" menu isnt one we add, MacOS puts it there even though we have our own... Ignore theirs, use ours

Mac stuff is hard, as I dont have one to test one );

[petervanderwalt]

Going to close this issue as the fixes will happen when we move to Electron 4 automatically