OpenByteDev / burnt-sushi

Spotify AdBlocker for Windows
MIT License
266 stars 10 forks source link

Impossible to start Burnt Sushi if Spotify is closed. #3

Closed ticpu closed 2 years ago

ticpu commented 2 years ago

According to the console output, it seems that if Spotify exists or isn't started, the app won't start. This prevents me from making it automatically start with the OS.

Example when restarting Spotify to fix connectivity issue with my phone.

[...]
[INFO] Unhooking Spotify...
[TRACE] Stopping RPC...
[TRACE] Stopped RPC
[INFO] Ejecting blocker...
[INFO] Ejected blocker
[INFO] Looking for Spotify...
[INFO] Shutting down...
[INFO] Exiting...

Example when Spotify isn't started.

[INFO] BurntSushi v0.1.0
[INFO] Looking for Spotify...
[INFO] Shutting down...
[INFO] Exiting...

I quickly checked and there's no option to keep the application running in --help and for more confusion, I see someone created issue #2 which mentions that the app stays running, but I don't know how it can be.

OpenByteDev commented 2 years ago

The app should be able to start and keep running if spotify is not. I think there is some error that occurs but is not logged which results in the application exiting.

OpenByteDev commented 2 years ago

Please try version 0.1.1

ticpu commented 2 years ago

Yes, that fixes it, thank you.

[INFO] Connected to 127.0.0.1:56764
[INFO] Unhooking Spotify...
[DEBUG] Stopping RPC...
[DEBUG] Stopped RPC
[INFO] Ejecting blocker...
[INFO] Ejected blocker
[INFO] Looking for Spotify...
[INFO] Found Spotify (PID=8)
[INFO] Loading filter config...
[DEBUG] Looking for filter config according to cli args...
[DEBUG] Looking for filter config next to executable...
[DEBUG] Looking for filter config at 
[DEBUG] Loading default filter config...
[INFO] Preparing blocker...
[DEBUG] Looking for blocker according to cli args...
[DEBUG] Looking for blocker next to executable...
[DEBUG] Looking for blocker at 
[DEBUG] Looking for existing blocker in temporary directory...
[DEBUG] Looking for blocker 
[DEBUG] Found blocker 
[INFO] Injecting blocker...
[DEBUG] Starting RPC...
[INFO] Blocker up and running!
[INFO] Connected to 127.0.0.1:51555