OpenC2SIM / C2SIMArtifacts

C2SIM Artifacts
MIT License
4 stars 5 forks source link

Move TemporalConcept to Relationship #17

Open clblais opened 2 years ago

clblais commented 2 years ago

C2SIM Problem Report / Change Request Submitter Name (s): Curtis Blais for Geir Sletten and Ole Martin Mevassvik Contact email address: Geir.Sletten@ffi.no, Ole-Martin.Mevassvik@ffi.no Submitter Organization(s): FFI Date of Submission: 23 May 2022 Type (Problem Report or Change Request): Problem Report Product: Core Ontology Problem/Change Description: From: Evaluation of C2SIM for use in Army Course of Action simulation, 22 February 2022, p 12

The TemporalConcept element under PhysicalConcept seems not to be related to the parent element or the other sibling elements. The proposal is to move it to Relationship.

MagdalenaDechand commented 2 years ago

Why would you treat time ("TemporalConcept") different to space ("Location")? Both can be defined in relation to an entity or event.

MagdalenaDechand commented 2 years ago

Actually, the class "Relationship" seems confusing as relationships between classes (or instances) are usually defined with the help of object properties (and restrictions). It just serves as auxiliary construct to group further aspects of specific relationships.

MagdalenaDechand commented 2 years ago

Action is restricted by "hasActionTemporalRelationship min 0 ActionTemporalRelationship" to refer to a bunch of temporal relationships at the same time. ActionTemporalRelationship refers back to TemporalConcept which bears the actual time notation. TemporalConcepts such as Duration, TimeInstant etc. are specified on a lower level either with datatype or object property restrictions. Thus, TemporalConcept is just a superordinate term for better readability.

What is the purpose of that change request? Does the empty class cause any issues?