Closed sunws4me closed 1 month ago
I think this is as expected. The filename is based on the data extraction start time field. (Not current system clock time)
Hello, Just thought it was odd to have a static file name on the output, current system time is a nice incrementing value and then the user gets an easy history without doing any work to sort it out and rename files.
From: Ryan Melton @.> Sent: Tuesday, July 16, 2024 3:49 PM To: OpenC3/cosmos @.> Cc: Brandon Carder @.>; Author @.> Subject: Re: [OpenC3/cosmos] Data Extractor file name times not picking up current time (Issue #1409)
I think this is as expected. The filename is based on the data extraction start time field. (Not current system clock time)
— Reply to this email directly, view it on GitHubhttps://github.com/OpenC3/cosmos/issues/1409#issuecomment-2231882684, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFUDQGXV7QX7HMXVRLARDPDZMWIOPAVCNFSM6AAAAABK7MYLWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRHA4DENRYGQ. You are receiving this because you authored the thread.Message ID: @.**@.>>
We could potentially have different file naming modes, but I like how it currently works. It relates to what you are extracting, rather than whatever time it happens to be right now.
A little confused by that, ‘relates to what you are extracting’. The file name stays static from when you went to the page and doesn’t change, that’s not going to relate to anything the user is doing its just a random point in time, not where they were on 9/11….. system time as part of the output name wouldn’t relate either, just a name that would be changing over time and not include the dup markings (1), (2), …
I haven’t done the save/load, if I load a saved config, will the name of the config be part of the output name? that would be a piece of meaningful data if its part of the filename (mine would be bob so maybe not for me!)
Since its saving to a file its really not a big deal, everything I’ve done in my history has always included system time at least so I thought it was a bug.
From: Ryan Melton @.> Sent: Tuesday, July 16, 2024 3:58 PM To: OpenC3/cosmos @.> Cc: Brandon Carder @.>; Author @.> Subject: Re: [OpenC3/cosmos] Data Extractor file name times not picking up current time (Issue #1409)
We could potentially have different file naming modes, but I like how it currently works. It relates to what you are extracting, rather than whatever time it happens to be right now.
— Reply to this email directly, view it on GitHubhttps://github.com/OpenC3/cosmos/issues/1409#issuecomment-2231892551, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFUDQGS7NDU3PLYX5A7FVATZMWJP3AVCNFSM6AAAAABK7MYLWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRHA4TENJVGE. You are receiving this because you authored the thread.Message ID: @.**@.>>
Its not a random point in time. Its the time in the start field.
Thanks I was missing that piece.
From: Ryan Melton @.> Sent: Tuesday, July 16, 2024 4:54 PM To: OpenC3/cosmos @.> Cc: Brandon Carder @.>; Author @.> Subject: Re: [OpenC3/cosmos] Data Extractor file name times not picking up current time (Issue #1409)
Its not a random point in time. Its the time in the start field.
— Reply to this email directly, view it on GitHubhttps://github.com/OpenC3/cosmos/issues/1409#issuecomment-2231949353, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFUDQGT7N34HIZCUDYOIHU3ZMWQCHAVCNFSM6AAAAABK7MYLWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRHE2DSMZVGM. You are receiving this because you authored the thread.Message ID: @.**@.>>
time does not change on multiple runs of data extractor over different system clock times.
setup a data extraction and repeated running over multiple seconds, however, the filename on each output was the same - the seconds field did not increment to match the actual run time
clicking into packet viewer and back to data extractor and rerunning does get a new timestamp as part of the new file name.![image](https://github.com/user-attachments/assets/38fadd3a-d4a6-47c2-b834-2a1186a73dad)