OpenC3 / cosmos

OpenC3 COSMOS
https://openc3.com
Other
111 stars 31 forks source link

Make Bearer optional in token to fix web_socket_api #1675

Closed ryanmelt closed 3 weeks ago

ryanmelt commented 4 weeks ago

Fixes differences between Open Source and Enterprise

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ryanmelt commented 4 weeks ago

Yes #1417 was only a partial fix that broke open source.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (6cc33e6) to head (a08a038). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/script/web_socket_api.rb 0.00% 3 Missing :warning:
openc3/lib/openc3/utilities/authentication.rb 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1675 +/- ## ========================================== + Coverage 76.50% 76.53% +0.02% ========================================== Files 618 618 Lines 46933 46937 +4 Branches 850 850 ========================================== + Hits 35908 35922 +14 + Misses 10930 10920 -10 Partials 95 95 ``` | [Flag](https://app.codecov.io/gh/OpenC3/cosmos/pull/1675/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | Coverage Δ | | |---|---|---| | [frontend](https://app.codecov.io/gh/OpenC3/cosmos/pull/1675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `56.26% <ø> (+0.20%)` | :arrow_up: | | [python](https://app.codecov.io/gh/OpenC3/cosmos/pull/1675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `83.96% <ø> (+<0.01%)` | :arrow_up: | | [ruby-api](https://app.codecov.io/gh/OpenC3/cosmos/pull/1675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `48.74% <ø> (ø)` | | | [ruby-backend](https://app.codecov.io/gh/OpenC3/cosmos/pull/1675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `82.52% <25.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.