OpenC3 / cosmos

OpenC3 COSMOS
https://openc3.com
Other
111 stars 31 forks source link

Python Mqtt and exception cleanup #1701

Open jmthomas opened 1 week ago

jmthomas commented 1 week ago

closes #1197

Sorry for the noise in there about the exceptions but I started in on it during MQTT implementation and it all sort of rolled together. I removed the ssl parameter because I don't think it makes sense by itself and only applies if an option is set. That is breaking but this is COSMOS 6 and I think the MQTT usage is pretty low.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.62%. Comparing base (792980a) to head (81c6863). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/streams/serial_stream.rb 80.00% 2 Missing :warning:
openc3/lib/openc3/models/interface_model.rb 0.00% 1 Missing :warning:
openc3/lib/openc3/models/tool_model.rb 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1701 +/- ## ========================================== + Coverage 76.31% 76.62% +0.30% ========================================== Files 603 608 +5 Lines 46101 46487 +386 Branches 844 844 ========================================== + Hits 35183 35619 +436 + Misses 10821 10771 -50 Partials 97 97 ``` | [Flag](https://app.codecov.io/gh/OpenC3/cosmos/pull/1701/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | Coverage Δ | | |---|---|---| | [frontend](https://app.codecov.io/gh/OpenC3/cosmos/pull/1701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `56.18% <ø> (-0.12%)` | :arrow_down: | | [python](https://app.codecov.io/gh/OpenC3/cosmos/pull/1701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `84.21% <ø> (+0.24%)` | :arrow_up: | | [ruby-api](https://app.codecov.io/gh/OpenC3/cosmos/pull/1701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `48.70% <ø> (ø)` | | | [ruby-backend](https://app.codecov.io/gh/OpenC3/cosmos/pull/1701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3) | `82.56% <95.45%> (+0.39%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OpenC3#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
25.0% Duplication on New Code

See analysis details on SonarQube Cloud