search

OpenC3 / openc3-cosmos-cfdp

Other
1 stars 1 forks source link

File Directive PDU data length field is off by 1 #5

Closed avan989 closed 10 months ago

avan989 commented 10 months ago

From the code, it looks like the "PDU data length" for the File Directive does not include the directive code. From CCSDS 727.0-B-5 Section 5.2.1.1

The data field of File Directives shall consist of a Directive Code octet followed by a Directive Parameter field

Example from cfdp_pdu_eof.rb: https://github.com/OpenC3/openc3-cosmos-cfdp/blob/fa4b65f1928dd54ceeeb074f021b97f2711757b0/microservices/CFDP/lib/cfdp_pdu/cfdp_pdu_eof.rb#L41-L47

ryanmelt commented 10 months ago

You are correct. Fill fix.