OpenCCG / openccg

OpenCCG library for parsing and realization with CCG
http://openccg.sourceforge.net/
Other
205 stars 45 forks source link

Update NERApp to be compatible with current Stanford Core NLP #12

Closed dmhowcroft closed 6 years ago

dmhowcroft commented 7 years ago

The constructor we were using now requires an additional arg.

Not doing anything clever or changing behavior, just added in 'false' for the new arg.

See the current version of NERClassifierCombiner.java to see the affected methods: https://github.com/stanfordnlp/CoreNLP/blob/master/src/edu/stanford/nlp/ie/NERClassifierCombiner.java#L103 (and the same method def in Stanford Core NLP v. 1.3.4 if you're interested).

Also, looks like this branch ended up including my patch for the 'includeantruntime' problem in the build file--sorry!